lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Aug 2010 17:40:42 -0700 (PDT) From: Dan Magenheimer <dan.magenheimer@...cle.com> To: Jeremy Fitzhardinge <jeremy@...p.org> Cc: Chris Mason <chris.mason@...cle.com>, viro@...iv.linux.org.uk, akpm@...ux-foundation.org, adilger@....com, tytso@....edu, mfasheh@...e.com, Joel Becker <joel.becker@...cle.com>, matthew@....cx, linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, ocfs2-devel@....oracle.com, linux-mm@...ck.org, ngupta@...are.org, JBeulich@...ell.com, Kurt Hackel <kurt.hackel@...cle.com>, npiggin@...nel.dk, Dave Mccracken <dave.mccracken@...cle.com>, riel@...hat.com, avi@...hat.com, Konrad Wilk <konrad.wilk@...cle.com>, mel@....ul.ie, yinghan@...gle.com, gthelen@...gle.com Subject: RE: [PATCH V4 3/8] Cleancache: core ops functions and configuration > > +#ifdef CONFIG_CLEANCACHE > > +#define cleancache_enabled (cleancache_ops.init_fs) > > Pointers can be used in a boolean context, but it would probably be > cleaner to have this evaluate to a proper boolean type. Also I'd > probably go with an all-caps macro name rather than making it look like > a variable. OK, thanks, will fix. > > +/* useful stats available in /sys/kernel/mm/cleancache */ > > +static unsigned long succ_gets; > > +static unsigned long failed_gets; > > +static unsigned long puts; > > +static unsigned long flushes; > > I'd probably give these very generic-sounding names some slightly > unique > prefix just to help out people looking at "nm" output or using ctags. > > > +static int get_key(struct inode *inode, struct cleancache_filekey > *key) > > Ditto. OK, will do. Thanks for the feedback! Dan -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists