lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Dec 2010 08:06:27 -0500 From: Ted Ts'o <tytso@....edu> To: Lukas Czerner <lczerner@...hat.com> Cc: sandeen@...hat.com, linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext4: Remove warning message from ext4_issue_discard helper On Tue, Nov 23, 2010 at 07:42:03PM +0100, Lukas Czerner wrote: > ext4_issue_discard is supposed to be helper for calling discard, however > in case that underlying device does not support discard it prints out > the warning message and clears the DISCARD t_mount_opt flag. Since it > can be (and is) used by others, it should not do anything and let the > caller to handle the error case. > > This commit removes warning message and flag setting from > ext4_issue_discard and use it just in place where it is really needed > (release_blocks_on_commit). FITRIM ioctl should not set any flags nor it > should print out warning messages, so get rid of the warning as well. > > Signed-off-by: Lukas Czerner <lczerner@...hat.com> Added to the ext4 patch queue, thanks for the ping. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists