linux-ext4 - Re: [PATCH] ext4: Fix missing iput for root inode in case of all failed mount paths.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 26 Feb 2011 13:35:05 -0800
From:	Manish Katiyar <mkatiyar@...il.com>
To:	"Ted Ts'o" <tytso@....edu>
Cc:	Andreas Dilger <adilger@...ger.ca>,
	ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: Fix missing iput for root inode in case of all
 failed mount paths.

On Mon, Feb 7, 2011 at 3:31 PM, Manish Katiyar <mkatiyar@...il.com> wrote:
> On Mon, Feb 7, 2011 at 3:23 PM, Ted Ts'o <tytso@....edu> wrote:
>> On Sat, Jan 29, 2011 at 09:40:34PM -0800, Manish Katiyar wrote:
>>>
>>> Any feedback on this ?
>>
>> The patch looks good, but it doesn't fix bug #26752.
>>
>> The root cause of that bug is the fact that ext4_sync_fs() and
>> ext4_put_super() assumes that sbi has been initialized.

Hi Ted,

Is there anything else that I need to do to get this merged in your tree ?

>
> Hmm.. Actually I was looking at generic_super_shutdown() which I
> thought would call ext4_put_super() only if sb->root is set, and since
> I was setting sb->root explicitly to NULL in my patch in case of
> failures.
>
> --
> Thanks -
> Manish
>



-- 
Thanks -
Manish
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html