linux-ext4 - Re: [PATCH] ext3: Fix an overflow in ext3_trim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 4 Mar 2011 00:40:47 +0100
From:	Jan Kara <jack@...e.cz>
To:	Tao Ma <tm@....ma>
Cc:	linux-ext4@...r.kernel.org, Lukas Czerner <lczerner@...hat.com>,
	Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] ext3: Fix an overflow in ext3_trim_fs.

On Thu 03-03-11 22:58:37, Tao Ma wrote:
> From: Tao Ma <boyu.mt@...bao.com>
> 
> In a bs=4096 volume, if we call FITRIM with the following parameter as
> fstrim_range(start = 102400, len = 134144000, minlen = 10240), with the
> following code:
> if (len >= EXT3_BLOCKS_PER_GROUP(sb))
>         len -= (EXT3_BLOCKS_PER_GROUP(sb) - first_block);
> else
>         last_block = first_block + len;
> 
> So if len < EXT3_BLOCKS_PER_GROUP while first_block + len >
> EXT3_BLOCKS_PER_GROUP, last_block will be set to an overflow value
> which exceeds EXT3_BLOCKS_PER_GROUP.
> 
> This patch fixes it and adjusts len and last_block accordingly.
  Thanks. Merged.

								Honza

-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html