linux-ext4 - Re: [PATCH] ext4: remove the duplicate set_buffer_mapped() for ext4_da_get_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Mar 2011 14:05:45 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Feng Tang <feng.tang@...el.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: remove the duplicate set_buffer_mapped() for
 ext4_da_get_block_prep()

Thanks, added to the ext4 patch tree.

						- Ted

On Tue, Feb 22, 2011 at 03:40:38PM +0800, Feng Tang wrote:
> The map_bh() called right before it already set the buffer_head to mapped.
> 
> Signed-off-by: Feng Tang <feng.tang@...el.com>
> ---
>  fs/ext4/inode.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 9f7f9e4..6fe60f5 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -2597,7 +2597,6 @@ static int ext4_da_get_block_prep(struct inode *inode, sector_t iblock,
>  		 * for partial write.
>  		 */
>  		set_buffer_new(bh);
> -		set_buffer_mapped(bh);
>  	}
>  	return 0;
>  }
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html