linux-ext4 - Re: [PATCH] e2fsprogs: create com

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2011 15:39:07 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	"Ted Ts'o" <tytso@....edu>
CC:	ext4 development <linux-ext4@...r.kernel.org>, mitchb@....edu,
	Bruce Cassidy <bruce@...mcloud.com>
Subject: Re: [PATCH] e2fsprogs: create com_err.h symlink in includedir

On 3/19/11 10:03 AM, Eric Sandeen wrote:
> On 2/20/11 5:10 PM, Ted Ts'o wrote:
>> On Wed, Feb 16, 2011 at 12:01:39PM -0600, Eric Sandeen wrote:
>>> After debian bug #192277, debian/rules started making a symlink
>>> to com_err.h in /usr/include.  Now I have Fedora bug #550889
>>> for the same issue, and perhaps it's time to make this symlink
>>> by default, rather than fixing it up in packaging steps?
>>>
>>> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
>>
>> Pulled into the e2fsprogs tree, with the following change:
>>
>>     [ Changed by tytso to remove the explicit -s option; this will
>>       default to creating a hard link by default, which slightly faster.
>>       If people want to use symlinks for all links during the install
>>       process, they can use configure option --enable-symlink-install.
>>       The reason for this change is that some file systems, like AFS,
>>       don't support symlinks, and AFS users complain when they can't build
>>       or install into AFS.  So I don't want to use symlinks
>>       unconditionally without a way of switching things back and forth,
>>       and it's easier if we just make all links made during the install
>>       process to be hard links or sym links. ]
>>
>>
>>       	      	    	       	      	     - Ted
> 
> Hm, now in a "make rpm" build which has source in one place and rpm build
> area in another:
> 
> /bin/ln: creating hard link `/home/sandeen/rpmbuild/BUILDROOT/e2fsprogs-1.41.14-0.x86_64/usr/include/com_err.h' => `/usr/include/et/com_err.h': Invalid cross-device link
> 
> so I'm not quite sure how to work around this.
> 
> Maybe in the end it does have to be packaging-specific, with the
> link created by the distro pkg scripts...?

Ted, your change broke any builds span 2 different filesystems.

Now what?

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html