linux-ext4 - Re: [PATCH v2] ext4: quiet 'unused variables' compiling warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Jun 2011 11:33:53 +0200 (CEST)
From:	Lukas Czerner <lczerner@...hat.com>
To:	Yongqiang Yang <xiaoqiangnk@...il.com>
cc:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2] ext4: quiet 'unused variables' compiling warnings

On Tue, 28 Jun 2011, Yongqiang Yang wrote:

> Unused variables was deleted.
> 
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>
> ---
>  fs/ext4/extents.c |    2 --
>  fs/ext4/mballoc.c |    2 --
>  2 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index f815cc8..94940aa 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -3107,12 +3107,10 @@ static int ext4_convert_unwritten_extents_endio(handle_t *handle,
>  					      struct ext4_ext_path *path)
>  {
>  	struct ext4_extent *ex;
> -	struct ext4_extent_header *eh;
>  	int depth;
>  	int err = 0;
>  
>  	depth = ext_depth(inode);
> -	eh = path[depth].p_hdr;
>  	ex = path[depth].p_ext;
>  
>  	ext_debug("ext4_convert_unwritten_extents_endio: inode %lu, logical"
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 6ed859d..389386b 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -4666,12 +4666,10 @@ void ext4_add_groupblocks(handle_t *handle, struct super_block *sb,
>  	struct ext4_buddy e4b;
>  	int err = 0, ret, blk_free_count;
>  	ext4_grpblk_t blocks_freed;
> -	struct ext4_group_info *grp;
>  
>  	ext4_debug("Adding block(s) %llu-%llu\n", block, block + count - 1);
>  
>  	ext4_get_group_no_and_offset(sb, block, &block_group, &bit);
> -	grp = ext4_get_group_info(sb, block_group);
>  	/*
>  	 * Check to see if we are freeing blocks across a group
>  	 * boundary.
> 

Patch looks good. Thanks!
-Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html