linux-ext4 - [patch] ext4: add a kfree() on error i add_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 30 Jul 2011 11:25:57 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Theodore Ts'o <tytso@....edu>
Cc:	Andreas Dilger <adilger.kernel@...ger.ca>,
	"open list:EXT4 FILE SYSTEM" <linux-ext4@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: [patch] ext4: add a kfree() on error i add_new_gdb()

We added some more error handling in b40971426a "ext4: add error
checking to calls to ext4_handle_dirty_metadata()".  But we need to
call kfree() as well to avoid a memory leak.

Signed-off-by: Dan Carpenter <error27@...il.com>

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 6e3327d..71085df 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -517,6 +517,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode,
 	return err;
 
 exit_inode:
+	kfree(n_group_desc);
 	/* ext4_handle_release_buffer(handle, iloc.bh); */
 	brelse(iloc.bh);
 exit_dindj:
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html