linux-ext4 - Re: [PATCH] ext4: fix races in ext4_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 30 Jul 2011 17:42:42 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Ted Ts'o <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: fix races in ext4_sync_parent()

On Sat, Jul 30, 2011 at 12:32:04PM -0400, Ted Ts'o wrote:
> 		spin_lock(&inode->i_lock);
> 		if (!list_empty(&inode->i_dentry)) {
> 			dentry = list_first_entry(&inode->i_dentry,
> 						  struct dentry, d_alias);
> 			dget(dentry);
> 		}
> 		spin_unlock(&inode->i_lock);

		dentry = d_find_alias(inode);
actually...

> 		if (!dentry)
> 			break;

> 		next = igrab(dentry->d_parent->d_inode);

and that one needs dentry->d_lock around it, to stabilize ->d_parent.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html