lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Sep 2011 15:56:31 +0200 From: Johannes Weiner <jweiner@...hat.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Mel Gorman <mgorman@...e.de>, Christoph Hellwig <hch@...radead.org>, Dave Chinner <david@...morbit.com>, Wu Fengguang <fengguang.wu@...el.com>, Jan Kara <jack@...e.cz>, Rik van Riel <riel@...hat.com>, Minchan Kim <minchan.kim@...il.com>, Chris Mason <chris.mason@...cle.com>, "Theodore Ts'o" <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, xfs@....sgi.com, linux-btrfs@...r.kernel.org, linux-ext4@...r.kernel.org, linux-mm@...ck.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, Josef Bacik <josef@...hat.com> Subject: Re: [patch 4/4] Btrfs: pass __GFP_WRITE for buffered write page allocations On Tue, Sep 20, 2011 at 03:45:15PM +0200, Johannes Weiner wrote: > Tell the page allocator that pages allocated for a buffered write are > expected to become dirty soon. > > Signed-off-by: Johannes Weiner <jweiner@...hat.com> > --- > fs/btrfs/file.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c > index e7872e4..ea1b892 100644 > --- a/fs/btrfs/file.c > +++ b/fs/btrfs/file.c > @@ -1084,7 +1084,7 @@ static noinline int prepare_pages(struct btrfs_root *root, struct file *file, > again: > for (i = 0; i < num_pages; i++) { > pages[i] = find_or_create_page(inode->i_mapping, index + i, > - GFP_NOFS); > + GFP_NOFS | __GFP_WRITE); Btw and unrelated to this particular series, I think this should use grab_cache_page_write_begin() in the first place. Most grab_cache_page calls were replaced recently (a94733d "Btrfs: use find_or_create_page instead of grab_cache_page") to be able to pass GFP_NOFS, but the pages are now also no longer __GFP_HIGHMEM and __GFP_MOVABLE, which irks both x86_32 and memory hotplug. It might be better to change grab_cache_page instead to take a flags argument that allows passing AOP_FLAG_NOFS and revert the sites back to this helper? -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists