lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Oct 2011 21:36:13 +0800 From: Yongqiang Yang <xiaoqiangnk@...il.com> To: tytso@....edu Cc: linux-ext4@...r.kernel.org, Yongqiang Yang <xiaoqiangnk@...il.com> Subject: Re: [PATCH 3/3] ext4: let ext4_discard_partial_buffers handle unaligned range correctly Forgot to say that the bug was found by running xfstests 91. Thx! Yongqiang. On Sun, Oct 30, 2011 at 7:30 PM, Yongqiang Yang <xiaoqiangnk@...il.com> wrote: > As comment says, we should handle unaligned range rather than aligned > one. > > Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com> > --- > fs/ext4/inode.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index e113de8..f97d671 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -3209,8 +3209,8 @@ int ext4_discard_partial_page_buffers_no_lock(handle_t *handle, > * to be updated with the contents of the block before > * we write the zeros on top of it. > */ > - if (!(from & (blocksize - 1)) || > - !((from + length) & (blocksize - 1))) { > + if ((from & (blocksize - 1)) || > + ((from + length) & (blocksize - 1))) { > create_empty_buffers(page, blocksize, 0); > } else { > /* > -- > 1.7.5.1 > > -- Best Wishes Yongqiang Yang -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists