linux-ext4 - Re: [PATCH] ext4: let ext4_ext_convet_to_initialized initialize var(eh) before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 1 Nov 2011 18:52:22 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Yongqiang Yang <xiaoqiangnk@...il.com>
Cc:	linux-ext4@...r.kernel.org, Eric Gouriou <egouriou@...gle.com>
Subject: Re: [PATCH] ext4: let ext4_ext_convet_to_initialized initialize
 var(eh) before using it

On Tue, Nov 01, 2011 at 09:21:21AM +0800, Yongqiang Yang wrote:
> ext4_ext_convert_to_initialized() does not initialize eh before using it
> and this is introduced in commit 864d21652.
> 
> Cc:Eric Gouriou <egouriou@...gle.com>
> Cc:"Theodore Ts'o" <tytso@....edu>
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>

>  		eof_block = map->m_lblk + map->m_len;
>  
>  	depth = ext_depth(inode);
> +	eh = path[depth].p_hdr;
>  	ex = path[depth].p_ext;
>  	ee_block = le32_to_cpu(ex->ee_block);
>  	ee_len = ext4_ext_get_actual_len(ex);

Hmmm, nice catch.

Looks like Eric dropped this line when he forward ported this patch to
v3.1.  Interestingly, I did test this using xfstests, and it didn't
complain.  Which probably means we don't have a good test coverage
that triggers the specific preconditions of this optimization.  Oops.
I'll fix this up now.

Eric, when you have a chance, could you work up an xfstests test that
automates the various tests that you ran manually when you developed
this patch?  Thanks!!

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html