lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 01 Dec 2011 12:14:24 -0800 From: "Darrick J. Wong" <djwong@...ibm.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Theodore Tso <tytso@....edu>, Joakim Tjernlund <joakim.tjernlund@...nsmode.se>, Bob Pearson <rpearson@...temfabricworks.com>, linux-kernel <linux-kernel@...r.kernel.org>, Andreas Dilger <adilger.kernel@...ger.ca>, linux-crypto <linux-crypto@...r.kernel.org>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, Mingming Cao <cmm@...ibm.com>, linux-ext4@...r.kernel.org, Herbert Xu <herbert@...dor.apana.org.au> Subject: [PATCH 06/14] crc32: Fix mixing of endian-specific types crc32.c in its original version freely mixed u32, __le32 and __be32 types which caused warnings from sparse with __CHECK_ENDIAN__. This patch fixes these by forcing the types to u32. From: Bob Pearson <rpearson@...temfabricworks.com> Signed-off-by: Bob Pearson <rpearson@...temfabricworks.com> [djwong@...ibm.com: Minor changelog tweaks] Signed-off-by: Darrick J. Wong <djwong@...ibm.com> --- lib/crc32.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/crc32.c b/lib/crc32.c index 2a87ea2..ff6bb9a 100644 --- a/lib/crc32.c +++ b/lib/crc32.c @@ -28,13 +28,13 @@ #include "crc32defs.h" #if CRC_LE_BITS == 8 -# define tole(x) __constant_cpu_to_le32(x) +# define tole(x) (__force u32) __constant_cpu_to_le32(x) #else # define tole(x) (x) #endif #if CRC_BE_BITS == 8 -# define tobe(x) __constant_cpu_to_be32(x) +# define tobe(x) (__force u32) __constant_cpu_to_be32(x) #else # define tobe(x) (x) #endif @@ -128,9 +128,9 @@ u32 __pure crc32_le(u32 crc, unsigned char const *p, size_t len) # elif CRC_LE_BITS == 8 const u32 (*tab)[] = crc32table_le; - crc = __cpu_to_le32(crc); + crc = (__force u32) __cpu_to_le32(crc); crc = crc32_body(crc, p, len, tab); - crc = __le32_to_cpu(crc); + crc = __le32_to_cpu((__force __le32)crc); #endif return crc; } @@ -171,9 +171,9 @@ u32 __pure crc32_be(u32 crc, unsigned char const *p, size_t len) # elif CRC_BE_BITS == 8 const u32 (*tab)[] = crc32table_be; - crc = __cpu_to_be32(crc); + crc = (__force u32) __cpu_to_be32(crc); crc = crc32_body(crc, p, len, tab); - crc = __be32_to_cpu(crc); + crc = __be32_to_cpu((__force __be32)crc); # endif return crc; } -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists