linux-ext4 - Re: [PATCH 2/2] ext4: ext4_discard_partial_page_buffers_no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Dec 2011 01:40:47 +0100
From:	Andrea Arcangeli <aarcange@...hat.com>
To:	Allison Henderson <achender@...ux.vnet.ibm.com>
Cc:	Yongqiang Yang <xiaoqiangnk@...il.com>, linux-ext4@...r.kernel.org,
	Theodore Tso <tytso@....edu>, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH 2/2] ext4: ext4_discard_partial_page_buffers_no_lock()
 wrong parameters

Hi Allison,

On Mon, Dec 12, 2011 at 01:07:47PM -0700, Allison Henderson wrote:
> Hi Andrea,
> 
> I think what Yongqiang means is that the code you are modifying is being 
> removed in the patches listed above and replaced with a different 
> solution.  The patches have not yet been merged so you will not see them 
> in a git tree yet, so you will need to apply them yourself.  If you are 
> not subscribed to the list, you can still find the patches here:
> 
> http://www.spinics.net/lists/linux-ext4/msg29109.html
> http://www.spinics.net/lists/linux-ext4/msg29110.html
> 
> http://www.spinics.net/lists/linux-ext4/msg29375.html
> http://www.spinics.net/lists/linux-ext4/msg29376.html

Thanks for the links. Applied all 4.

> We want to make sure the solution works for everyone, so please apply 
> these patches and let us know if it corrects the issues you are seeing. 
>   Thx!

With all 4 patches applied, my 1/2 patch is still needed to avoid the
hang and writes hangs all the time (but now they don't return -EINVAL
anymore).

My patch 2/2 is not needed with the above 4 patches applied so that
can be discared if you apply the above 4 patches (but I suggest you
check my patch 2/2 too because if it happens to be correct it could
mean there's the potential of 1 byte data corruption in current
upstream kernels in some circumstances, in addition to the -EINVAL
failure in write()).

Let me know if you need me to test me anything else in relation to the
copied=0 case.

Thanks,
Andrea
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html