linux-ext4 - Re: [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 22 May 2012 14:02:17 -0500
From:	Eric Sandeen <sandeen@...deen.net>
To:	Eric Sandeen <sandeen@...hat.com>
CC:	Ted Ts'o <tytso@....edu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	manish honap <manish_honap_vit@...oo.co.in>,
	"adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio
 code.

On 5/22/12 11:11 AM, Eric Sandeen wrote:
> On 5/21/12 6:31 PM, Ted Ts'o wrote:
>> On Mon, May 21, 2012 at 03:22:28PM -0700, Linus Torvalds wrote:
>>>
>>> So I'm pretty sure this patch is what we want, and rw_verify_area()
>>> really is required to protect low-level filesystems from these kinds
>>> of issues. Not just ext4.
>>>
>>> At the same time, I would *really* want somebody who actually uses
>>> anything AIO to test it out too. Because I want to not only commit it,
>>> but also mark it for stable - and it would be nice to have some more
>>> testing than me saying "ok, it passes the one test-case sent to me"
>>> and "hey, the code looks sane".
> 
> Just FWIW, the ext4_file_write() part of this fix was sent by Zheng Liu on 4/12/12:
> 
> [PATCH RESEND] ext4: change return value from int to ssize_t in ext4_file_write

Sorry, I was talking about Manish's original patch, not Linus's followup.

-Eric

> I'll see about writing an xfstest for this stuff too so it doesn't regress again.
> 
> -Eric
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html