linux-ext4 - Re: [PATCH] tests: use make rules to run tests in parallel (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 29 May 2012 08:23:58 -0600
From:	Andreas Dilger <adilger@...mcloud.com>
To:	Ted Ts'o <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] tests: use make rules to run tests in parallel (v3)

On 2012-05-29, at 6:33 AM, Ted Ts'o wrote:
> On Tue, May 29, 2012 at 01:02:11AM -0600, Andreas Dilger wrote:
>> 
>> Hrm, one reason I made the generated files read-only is to avoid
>> accidentally editing the generated copy, and then losing the resulting
>> changes when the file is recreated (as happened several times with the
>> test_script file, when rebasing the patch).  I'd prefer to mark the
>> generated files read-only, and then have the Makefile rules delete the
>> file before recreating it.
> 
> I tend to just edit the foo.in file; the Makefile dependencies
> automatically take care of rebuiling the test_one and test_script
> files --- and it's much easier just to type "make" to retry the
> generated scripts....

Sure, that is what I'm trying to encourage.

>> That avoids accidentally having developers edit the file, while allowing
>> the always-remembering Makefile rule to recreate the file without errors.
> 
> Yeah, but I don't want to encourage developers editing generated
> files...  it's much better to make things much more convenient for
> them to do things in the "right" way.  In the long run that's much
> more effective at avoiding lost work, and it saves you effort (since
> otherwise you might forget to fix the foo.in file before you commit
> the change, etc.)

That's my whole point.  If the generated file is read-only, there is
no way to edit it, and no way to accidentally lose work.  Ideally,
everyone would remember to edit the .in files and this would not be
an issue.   In practise I find myself accidentally editing the
generated files, especially in cases where I don't even know that
the file is generated, since I'm not as familiar with the code as
you.  I expect most other developers are even less familiar than
I am with the generated files.

Cheers, Andreas
--
Andreas Dilger                       Whamcloud, Inc.
Principal Lustre Engineer            http://www.whamcloud.com/




--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html