linux-ext4 - Re: [PATCH 1/2] ext4: fix the comment in ext4_ext_insert_extent for ext4_ext_try_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 7 Jul 2012 23:15:06 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	Wang Sheng-Hui <shhuiw@...il.com>
Cc:	"Theodore Ts'o" <tytso@....edu>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ext4: fix the comment in ext4_ext_insert_extent for
 ext4_ext_try_to_merge in extents.c

Hi Sheng-Hui,

It seems that there has a patch to fix it.
http://www.spinics.net/lists/linux-ext4/msg32611.html

Regards,
Zheng

On Fri, Jul 6, 2012 at 2:26 PM, Wang Sheng-Hui <shhuiw@...il.com> wrote:
> The left and right extents merge is done by
> ext4_ext_try_to_merge. No specific left/right
> fun calls any more.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@...il.com>
> ---
>  fs/ext4/extents.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 5207b7b..6c2a37d 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -1891,12 +1891,10 @@ has_space:
>         nearex->ee_len = newext->ee_len;
>
>  merge:
> -       /* try to merge extents to the right */
> +       /* try to merge extents to the neighbours */
>         if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
>                 ext4_ext_try_to_merge(inode, path, nearex);
>
> -       /* try to merge extents to the left */
> -
>         /* time to correct all indexes above */
>         err = ext4_ext_correct_indexes(handle, inode, path);
>         if (err)
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html