linux-ext4 - Re: [PATCH 1/4] ext4: remove unsafe and unnecessary memset()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Nov 2012 14:20:42 +0100 (CET)
From:	Lukáš Czerner <lczerner@...hat.com>
To:	Guo Chao <yan@...ux.vnet.ibm.com>
cc:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/4] ext4: remove unsafe and unnecessary memset()

On Fri, 30 Nov 2012, Guo Chao wrote:

> Date: Fri, 30 Nov 2012 14:41:43 +0800
> From: Guo Chao <yan@...ux.vnet.ibm.com>
> To: tytso@....edu
> Cc: linux-ext4@...r.kernel.org
> Subject: [PATCH 1/4] ext4: remove unsafe and unnecessary memset()
> 
> We memset this page before checking whether it's valid. But we need
> not memset zeroed page at all.
> 
> Signed-off-by: Guo Chao <yan@...ux.vnet.ibm.com>
> ---
>  fs/ext4/super.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index ad6cd8a..66a4e20 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3206,7 +3206,6 @@ int ext4_calculate_overhead(struct super_block *sb)
>  	ext4_fsblk_t overhead = 0;
>  	char *buf = (char *) get_zeroed_page(GFP_KERNEL);
>  
> -	memset(buf, 0, PAGE_SIZE);
>  	if (!buf)
>  		return -ENOMEM;

Good catch, thanks!

Reviewed-by: Lukas Czerner <lczerner@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html