linux-ext4 - Re: jbd2: don't wake kjournald unnecessarily

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jan 2013 00:29:46 +0100
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	"Theodore Ts'o" <tytso@....edu>,
	Sedat Dilek <sedat.dilek@...il.com>, Jan Kara <jack@...e.cz>,
	Eric Sandeen <sandeen@...hat.com>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-next <linux-next@...r.kernel.org>, mszeredi@...e.cz
Subject: Re: jbd2: don't wake kjournald unnecessarily

On Tue, Jan 22, 2013 at 12:11 AM, Theodore Ts'o <tytso@....edu> wrote:
> On Tue, Jan 22, 2013 at 12:04:32AM +0100, Sedat Dilek wrote:
>>
>> Beyond the FUSE/LOOP fun, will you apply this patch to your linux-next GIT tree?
>>
>> Feel free to add...
>>
>>      Tested-by: Sedat Dilek <sedat.dilek@...il.com>
>>
>> A similiar patch for JBD went through your tree into mainline (see [1] and [2]).
>
> I'm not at all convinced that this patch has anything to do with your
> problem.  I don't see how it could affect things, and I believe you
> mentioned that you saw the problem even with this patch applied?  (I'm
> not sure; some of your messages which you sent were hard to
> understand, and you mentioned something about trying to send messages
> when low on sleep :-).
>

Even with little sleep I know what I have written.
YES, it didn't fix my problem but it also did not hurt my system.
I just run Linux Test Project w/o errors which also means nothing.
( Hmmm, I checked-out xfstests... did I compile it :-)? )

> In any case, the reason why I haven't pulled this patch into the ext4
> tree is because I was waiting for Eric and some of the performance
> team folks at Red Hat to supply some additional information about why
> this commit was making a difference in performance for a particular
> proprietary, closed source benchmark.
>

I am not following the linux-ext4/linux-fsdevel MLs so much, but IIRC
this patch is from December 2012.
An identical patch for JBD (approx. from same date) went upstream,
that's why I asked.
But now I know you care of JBD2 stuff :-).
Of course, I leave it to the experts to decide.
Come on Eric, open the pandora box and bomb Ted with logs and traces :-).

> I'm very suspicious about applying patches under the "cargo cult"
> school of programming.  ("We don't understand why it makes a
> difference, but it seems to be good, so bombs away!" :-)
>

A good attitude - a man we can trust!

I would liked to see a more positive development on my issue.
But I still see no real reason to throw this WUBI installation away
hitting a "corner" case.
It was done as a temporary installation and made me happy in my daily
working life.
If I will get unhappy I boot into Win7, oops.

- Sedat -

> Regards,
>
>                                         - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html