linux-ext4 - Re: [PATCH] Ext4: remove a useless check for the function ext4_data_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 27 Jan 2013 07:38:31 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Wang Shilong <wangshilong1991@...il.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] Ext4: remove a useless check for the function
 ext4_data_block_valid

On Sun, Jan 27, 2013 at 04:46:29PM -0800, Wang Shilong wrote:
> > Actually, it can be true --- if start_blk + count (which are both
> > unsigned integers) overflows....
>     Yeah,you are right....
>     I am sorry,I miss the overflow condition...

We added it because we saw a crash that was a caused by an overflow,
if memory serves correctly.  Or maybe it was a mysterious data or file
system corruption that was incredibly painful to find.

Fun trivia fact: the European Space Agency had the Ariane 5 rocket
explode on its maiden flight due to a integer overflow bug.

	       	      	     	      - Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html