[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 28 Jan 2013 13:06:32 -0500
From: Theodore Ts'o <tytso@....edu>
To: Jan Kara <jack@...e.cz>
Cc: linux-ext4@...r.kernel.org
Subject: Re: [PATCH 10/12] ext4: Simplify mpage_add_bh_to_extent()
On Fri, Jan 18, 2013 at 01:00:44PM +0100, Jan Kara wrote:
> The argument b_size of mpage_add_bh_to_extent() was bogus since it was
> always == blocksize (which we can easily derive from inode->i_blkbits).
> Also second branch of condition:
> if (nrblocks >= EXT4_MAX_TRANS_DATA) {
> } else if ((nrblocks + (b_size >> mpd->inode->i_blkbits)) >
> EXT4_MAX_TRANS_DATA) {
> }
> was never taken because (b_size >> mpd->inode->i_blkbits) == 1.
>
> Signed-off-by: Jan Kara <jack@...e.cz>
Thanks, applied.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists