linux-ext4 - Re: [PATCH] ext4: fix xattr block allocation/release with bigalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Feb 2013 12:25:45 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	Lukas Czerner <lczerner@...hat.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: fix xattr block allocation/release with bigalloc

On Mon, Feb 18, 2013 at 09:26:07AM -0600, Eric Sandeen wrote:
> On 2/18/13 2:14 AM, Lukas Czerner wrote:
> > Currently when new xattr block is created or released we we would call
> > dquot_free_block() or dquot_alloc_block() respectively, among the else
> > decrementing or incrementing the number of blocks assigned to the inode
> > by one block.
> > 
> > This however does not work for bigalloc file system because we always
> > allocate/free the whole cluster so we have to count with that in
> > dquot_free_block() and dquot_alloc_block() as well.
> > 
> > Use the clusters-to-blocks conversion EXT4_C2B() when passing number of
> > blocks to the dquot_alloc/free functions to fix the problem.
> > 
> > The problem has been revealed by xfstests #117 (and possibly others).
> > 
> > Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> 
> Reviewed-by: Eric Sandeen <sandeen@...hat.com>

Thanks, indeed.  Applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html