linux-ext4 - Re: [PATCH 2/7] ext4: fold ext4_generic_write_end() into ext4_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Mar 2013 16:35:09 +0100
From:	Jan Kara <jack@...e.cz>
To:	Theodore Ts'o <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	Zheng Liu <wenqing.lz@...bao.com>
Subject: Re: [PATCH 2/7] ext4: fold ext4_generic_write_end() into
 ext4_write_end()

On Sun 24-03-13 20:06:49, Ted Tso wrote:
> From: Zheng Liu <wenqing.lz@...bao.com>
> 
> After collpasing the handling of data ordered and data writeback
> codepath, ext4_generic_write_end() has only one caller,
> ext4_write_end().  So we fold it into ext4_write_end().
> 
> Signed-off-by: Zheng Liu <wenqing.lz@...bao.com>
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> ---
>  fs/ext4/inode.c | 67 +++++++++++++++++++++++----------------------------------
>  1 file changed, 27 insertions(+), 40 deletions(-)
> 
...
> @@ -1105,7 +1123,7 @@ static int ext4_generic_write_end(struct file *file,
>  
>  	/*
>  	 * No need to use i_size_read() here, the i_size
> -	 * cannot change under us because we hold i_mutex.
> +	 * cannot change under us because we hole i_mutex.
  Typo added here. Otherwise the patch is fine. You can add
Reviewed-by: Jan Kara <jack@...e.cz>

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html