linux-ext4 - Re: [ext4] extent tree es

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 2 May 2013 10:55:22 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	Jon ERNST <jonernst@....com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [ext4] extent tree es_len can be zero?

On Tue, Apr 30, 2013 at 12:59:19AM -0400, Jon ERNST wrote:
> Hi ,list,
> 
> extent tree es_len can be zero?
> if we call ext4_es_end when es_len is zero, it will have problem.
> 
> 
> diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
> index 95796a1..49a8da2 100644
> --- a/fs/ext4/extents_status.c
> +++ b/fs/ext4/extents_status.c
> @@ -108,7 +108,7 @@
>   *     tree are ordered by logical block no.
>   *
>   *   --        operations on a extent status tree
> - *     There are three important operations on a delayed extent tree: find
> + *     There are three important operations on a delayed extent tree: finding
>   *     next extent, adding a extent(a range of blocks) and removing a extent.
>   *
>   *   --        race on a extent status tree
> @@ -195,7 +195,7 @@ static void ext4_es_print_tree(struct inode *inode)
>  
>  static inline ext4_lblk_t ext4_es_end(struct extent_status *es)
>  {
> -       BUG_ON(es->es_lblk + es->es_len < es->es_lblk);
> +       BUG_ON(es->es_lblk + es->es_len <= es->es_lblk);

Hi Jon,

Thanks for looking at the code.  When ext4_es_end is called, es_len
shouldn't be zero because we always get 'es' from extent status tree,
and we never save an 'es' whose length is zero.  So we don't need to
worry about this.

Regards,
                                                - Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html