linux-ext4 - [PATCH] ext4: deleted unnecessary assignments and useless "if" statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Jun 2013 01:44:56 -0400
From:	"jon ernst" <jonernst07@....com>
To:	linux-ext4@...r.kernel.org
Subject: [PATCH] ext4: deleted unnecessary assignments and useless "if"
 statement

comparing unsigned variable with 0 always return false.
err = 0 is duplicated and unnecessary.

Signed-off-by: "Jon Ernst" <jonernst07@....com>

--- a/fs/ext4/inode.c     
+++ b/fs/ext4/inode.c     
@@ -1098,8 +1098,6 @@ static int ext4_write_end(struct file *f
        if (i_size_changed)
                ext4_mark_inode_dirty(handle, inode);

-       if (copied < 0)
-               ret = copied;
        if (pos + len > inode->i_size && ext4_can_truncate(inode))
                /* if we have allocated more blocks and copied
                 * less. We will have blocks allocated outside
@@ -3365,7 +3363,6 @@ int ext4_block_zero_page_range(handle_t
                pos += blocksize;
        }

-       err = 0;
        if (buffer_freed(bh)) {
                BUFFER_TRACE(bh, "freed: skip");
                goto unlock;
@@ -3405,7 +3402,6 @@ int ext4_block_zero_page_range(handle_t

        BUFFER_TRACE(bh, "zeroed end of block");

-       err = 0;
        if (ext4_should_journal_data(inode)) {
                err = ext4_handle_dirty_metadata(handle, inode, bh);
        } else {
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html