linux-ext4 - Re: Filesystem state: clean with errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 20 Jun 2013 19:01:53 -0400
From:	Autif Khan <autif.mlist@...il.com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	Eric Sandeen <sandeen@...hat.com>, linux-ext4@...r.kernel.org
Subject: Re: Filesystem state: clean with errors - what errors?

I am happy to report that upgrading from 1.42 to 1.42.7 has resolved
most of the issues. There is still one vendor where we are getting
corruption and we will avoid that vendor. We are small fish.

Thanks a lot to everyone that helped - specifically Eric, Ted and DJW

On Tue, Jun 4, 2013 at 9:49 AM, Theodore Ts'o <tytso@....edu> wrote:
> Hmm... what version of e2fsprogs are you using?  Is there any chance
> it's older than 1.42.4?  Hmmm, yes, you're using a positively ancient
> (and filled with bugs that have since been fixed e2fsprogs 1.42).
>
> I suspect you're getting hit bug a problem which we fixed in e2fsprogs
> 1.42.4 (and you *REALLY* want to upgrade to the latest released
> version of e2fsprogs):
>
>    Fixed e2fsck's handling of the journal's s_errno field.  E2fsck was
>    not properly propagating the journal's s_errno field to the superblock
>    field; it was not checking this field if the journal had already been
>    replayed, and if the journal *was* being replayed, the "error bit"
>    wasn't getting flushed out to disk.
>
> The kernel side fix for this particular issue (if this is what is
> going on) is:
>
> commit d796c52ef0b71a988364f6109aeb63d79c5b116b
> Author: Theodore Ts'o <tytso@....edu>
> Date:   Sun Aug 5 19:04:57 2012 -0400
>
>     ext4: make sure the journal sb is written in ext4_clear_journal_err()
>
>     After we transfer set the EXT4_ERROR_FS bit in the file system
>     superblock, it's not enough to call jbd2_journal_clear_err() to clear
>     the error indication from journal superblock --- we need to call
>     jbd2_journal_update_sb_errno() as well.  Otherwise, when the root file
>     system is mounted read-only, the journal is replayed, and the error
>     indicator is transferred to the superblock --- but the s_errno field
>     in the jbd2 superblock is left set (since although we cleared it in
>     memory, we never flushed it out to disk).
>
>     This can end up confusing e2fsck.  We should make e2fsck more robust
>     in this case, but the kernel shouldn't be leaving things in this
>     confused state, either.
>
>     Signed-off-by: "Theodore Ts'o" <tytso@....edu>
>     Cc: stable@...nel.org
>
> ... which first appeared in the 3.6 kernel, and which for some reason
> was never backported to the 3.2 stable series.
>
> Regards,
>
>                                                 - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html