linux-ext4 - unsigned/signed type mismatch in init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 7 Aug 2013 11:12:05 +0100
From:	Reece Dunn <msclrhd@...glemail.com>
To:	linux-ext4@...r.kernel.org
Subject: unsigned/signed type mismatch in init_bg overrun variable

Hi,

This was initially reported to the Android project at
http://code.google.com/p/android/issues/detail?id=58674 by someone
else.

284 u32 overrun = bg->first_block + info.blocks_per_group - aux_info.len_blocks;
285 if (overrun > 0)
286     reserve_blocks(bg, info.blocks_per_group - overrun, overrun);

Here, |reserve_blocks| is always called unless |bg->first_block +
info.blocks_per_group == aux_info.len_blocks| as overrun is unsigned
and the expression is signed.

The suggestion in the Android bug report was to change |overrun| to |s64|.

Thanks,
- Reece
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html