linux-ext4 - [RFC][PATCH] e2fsck: fix corrupted orphan list in preen mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 10 Oct 2013 15:55:19 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	linux-ext4@...r.kernel.org
Cc:	Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger@...ger.ca>,
	Eric Sandeen <sandeen@...hat.com>,
	Zheng Liu <wenqing.lz@...bao.com>
Subject: [RFC][PATCH] e2fsck: fix corrupted orphan list in preen mode

From: Zheng Liu <wenqing.lz@...bao.com>

Currently we don't try to fix the corrupted orphan list in preen mode.
When we meet this problem fsck will ask administrator to handle it.
But when application uses aio dio to manipulate the file and the server
gets a power failure or cold reset it is easy to trigger this problem.
If there is only one server, it is OK.  However, when a large number of
servers are reset, it is a disaster.

This commit makes e2fsck fix corrupted orphan list in preen mode, and
might make our lives better.

Cc: Theodore Ts'o <tytso@....edu>
Cc: Andreas Dilger <adilger@...ger.ca>
Cc: Eric Sandeen <sandeen@...hat.com>
Signed-off-by: Zheng Liu <wenqing.lz@...bao.com>
---
 e2fsck/problem.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/e2fsck/problem.c b/e2fsck/problem.c
index b0a6e19..29a6b5d 100644
--- a/e2fsck/problem.c
+++ b/e2fsck/problem.c
@@ -722,13 +722,13 @@ static struct e2fsck_problem problem_table[] = {
 	/* Deal with inodes that were part of orphan linked list */
 	{ PR_1_LOW_DTIME,
 	  N_("@i %i was part of the @o @i list.  "),
-	  PROMPT_FIX, PR_LATCH_LOW_DTIME, 0 },
+	  PROMPT_FIX, PR_LATCH_LOW_DTIME | PR_PREEN_OK, 0 },
 
 	/* Deal with inodes that were part of corrupted orphan linked
 	   list (latch question) */
 	{ PR_1_ORPHAN_LIST_REFUGEES,
 	  N_("@is that were part of a corrupted orphan linked list found.  "),
-	  PROMPT_FIX, 0 },
+	  PROMPT_FIX, PR_PREEN_OK },
 
 	/* Error allocating refcount structure */
 	{ PR_1_ALLOCATE_REFCOUNT,
-- 
1.7.9.7

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html