[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 13 Oct 2013 22:49:52 -0400
From: Theodore Ts'o <tytso@....edu>
To: Robert Yang <liezhi.yang@...driver.com>
Cc: linux-ext4@...r.kernel.org, dvhart@...ux.intel.com,
darrick.wong@...cle.com
Subject: Re: [PATCH 2/3 V4] debugfs.c: do sparse copy when src is a sparse
file
On Mon, Aug 26, 2013 at 02:22:03PM +0800, Robert Yang wrote:
> Let debugfs do sparse copy when src is a sparse file, just like
> "cp --sparse=auto"
>
> * For the:
> #define IO_BUFSIZE 64*1024
> this is a suggested value from gnu coreutils:
> http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blob;f=src/ioblksize.h;h=1ae93255e7d0ccf0855208c7ae5888209997bf16;hb=HEAD
>
> * Use malloc() to allocate memory for the buffer since put 64K (or
> more) on the stack seems not a good idea.
>
> Signed-off-by: Robert Yang <liezhi.yang@...driver.com>
> Acked-by: Darren Hart <dvhart@...ux.intel.com>
Applied, thanks.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists