lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Dec 2013 20:06:09 +0100 (CET) From: Andreas Gruenbacher <andreas.gruenbacher@...bit.com> To: Christoph Hellwig <hch@...radead.org> Cc: viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org, linux-btrfs@...r.kernel.org, linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, linux-mtd@...ts.infradead.org, Mark Fasheh <mfasheh@...e.com>, Joel Becker <jlbec@...lplan.org>, reiserfs-devel@...r.kernel.org, xfs@....sgi.com, jfs-discussion@...ts.sourceforge.net, cluster-devel@...hat.com, linux-nfs@...r.kernel.org, Jan Kara <jack@...e.cz> Subject: Re: [PATCH 02/18] fs: add get_acl helper Christoph, > +struct posix_acl *get_acl(struct inode *inode, int type) > +{ > + struct posix_acl *acl; > + > + acl = get_cached_acl(inode, type); > + if (acl != ACL_NOT_CACHED) > + return acl; > + > + if (!IS_POSIXACL(inode)) > + return NULL; > + > + /* > + * A filesystem can force a ACL callback by just never filling the > + * ACL cache. But normally you'd fill the cache either at inode > + * instantiation time, or on the first ->get_acl call. > + * > + * If the filesystem doesn't have a get_acl() function at all, we'll > + * just create the negative cache entry. > + */ > + if (!inode->i_op->get_acl) { > + set_cached_acl(inode, type, NULL); > + return ERR_PTR(-EAGAIN); The function should return NULL here. Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists