linux-ext4 - Re: [PATCH 5/8] xfstests: Add fallocate zero range operation to fsstress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 Feb 2014 11:40:08 -0600
From:	Eric Sandeen <sandeen@...deen.net>
To:	Lukas Czerner <lczerner@...hat.com>, linux-ext4@...r.kernel.org
CC:	linux-fsdevel@...r.kernel.org, xfs@....sgi.com
Subject: Re: [PATCH 5/8] xfstests: Add fallocate zero range operation to fsstress

On 2/28/14, 10:11 AM, Lukas Czerner wrote:
> This commit adds fzero operation support for fsstress, which is meant to
> exercise fallocate FALLOC_FL_ZERO_RANGE support.
> 
> Also reorganise the common fallocate code into a single do_fallocate()
> function and use flags use the right mode.
> 
> Also in order to make more obvious which fallocate mode fsstress is
> testing translate fallocate flags into human readable strings.

Can you enhance that so that if it's passed a flag which isn't
in the known array, it prints the leftover values?  Otherwise
they are silently dropped, which might be confusing.

Handling the case where a flag is not in the array would future-proof
it, I think.

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html