lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Mar 2014 19:02:16 +0100 (CET) From: Lukáš Czerner <lczerner@...hat.com> To: Christoph Hellwig <hch@...radead.org> cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, xfs@....sgi.com Subject: Re: [PATCH v2 6/8] fsstress: translate flags in fiemap_f On Thu, 6 Mar 2014, Christoph Hellwig wrote: > Date: Thu, 6 Mar 2014 09:48:13 -0800 > From: Christoph Hellwig <hch@...radead.org> > To: Lukas Czerner <lczerner@...hat.com> > Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, xfs@....sgi.com > Subject: Re: [PATCH v2 6/8] fsstress: translate flags in fiemap_f > > > +#ifdef HAVE_LINUX_FIEMAP_H > > +struct print_flags fiemap_flags[] = { > > + { FIEMAP_FLAG_SYNC, "SYNC"}, > > + { FIEMAP_FLAG_XATTR, "XATTR"}, > > + { -1, NULL} > > +}; > > Can be static. Right. The same applies to falloc_flags > > > + > > +#define translate_fiemap_flags(mode) \ > > + ({translate_flags(mode, "|", fiemap_flags);}) > > +#endif > > Any reason to not have these two inside fiemap_f? Not really, other than I think it's ugly. > > Otherwise: > > Reviewed-by: Christoph Hellwig <hch@....de> Thanks! -Lukas > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists