linux-ext4 - Re: [PATCH v3 10/30] libext2fs: define new dirent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Mar 2014 12:32:34 -0400
From:	jon ernst <jonernst07@...il.com>
To:	Theodore Ts'o <tytso@....edu>
Cc:	"linux-ext4@...r.kernel.org List" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH v3 10/30] libext2fs: define new dirent_swab interfaces for inline data

errcode_t ext2fs_dirent_swab_in(ext2_filsys fs, char *buf, int flags)
{
+       return ext2fs_dirent_swab_in(fs, buf, fs->blocksize, flags);
+}

I guess it misses "2" for function name.
Should be:

errcode_t ext2fs_dirent_swab_in(ext2_filsys fs, char *buf, int flags)
{
+       return ext2fs_dirent_swab_in2(fs, buf, fs->blocksize, flags);
+}

Thanks,
Jon

> On Mon, Mar 3, 2014 at 10:49 AM, Theodore Ts'o <tytso@....edu> wrote:
>> On Fri, Dec 06, 2013 at 05:57:57PM +0800, Zheng Liu wrote:
>> From: Zheng Liu <wenqing.lz@...bao.com>
>> 
>> Later we will use ext2fs_dirent_swab_in/out to handle big-endian problem
>> for inline data.  Now interfaces assume that it handles a block, but it
>> is not true after adding inline data.  So this commit defines a new
>> interface for inline data.
>> 
>> Signed-off-by: Zheng Liu <wenqing.lz@...bao.com>
> 
> Thanks, applied.
> 
>                                        - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html