linux-ext4 - Re: [PATCH] ext3: explicitly remove inode from orphan list after failed direct io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 Mar 2014 20:22:51 +0100
From:	Jan Kara <jack@...e.cz>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] ext3: explicitly remove inode from orphan list after
 failed direct io

On Mon 17-03-14 14:13:00, Eric Sandeen wrote:
> Otherwise non-empty orphan list will be triggered on umount.
> 
> This is just an application of commit da1daf by Dmitry Monakhov
> to the same code in ext3.
  Thanks, I've merged the patch.

							Honza
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> ---
> 
> diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
> index 384b6eb..caf4c4a 100644
> --- a/fs/ext3/inode.c
> +++ b/fs/ext3/inode.c
> @@ -1925,6 +1925,8 @@ retry:
>  			 * and pretend the write failed... */
>  			ext3_truncate_failed_direct_write(inode);
>  			ret = PTR_ERR(handle);
> +			if (inode->i_nlink)
> +				ext3_orphan_del(NULL, inode);
>  			goto out;
>  		}
>  		if (inode->i_nlink)
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html