linux-ext4 - RE: [PATCH 3/3] ext4: disable COLLAPSE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Apr 2014 20:27:00 +0900
From:	Namjae Jeon <namjae.jeon@...sung.com>
To:	'Lukáš Czerner' <lczerner@...hat.com>
Cc:	'Theodore Ts'o' <tytso@....edu>,
	'linux-ext4' <linux-ext4@...r.kernel.org>
Subject: RE: [PATCH 3/3] ext4: disable COLLAPSE_RANGE for bigalloc


> >  	}
> >
> > +	if (EXT4_SB(inode->i_sb)->s_cluster_ratio > 1) {
> > +		ret = -EOPNOTSUPP;
> > +		goto out_mutex;
> > +	}
> > +
> 
> I do not think we need to hold mutex for this. You can move it to
> the beginning of the function preferably right after S_ISREG check.
> 
> Otherwise it looks ok, but it would be better if we could fix it :)
Okay, Thanks for review!
> 
> Reviewed-by: Lukas Czerner <lczerner@...hat.com>
> 
> >  	truncate_pagecache_range(inode, ioffset, -1);
> >
> >  	/* Wait for existing dio to complete */
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html