linux-ext4 - compile warning on master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 May 2014 17:14:34 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Zheng Liu <wenqing.lz@...bao.com>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: compile warning on master


When compiling with LLVM, it generates the following warning in
debugfs::do_lsdel():

367 debugfs/lsdel.c:155 col 23: warning: '&&' within '||'
[-Wlogical-op-parentheses]
368:                if (lsd.free_blocks && !lsd.bad_blocks ||
369:                    ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ ~~
370 debugfs/lsdel.c:155 col 23: note: place parentheses around the '&&'
expression to silence this warning
371:                if (lsd.free_blocks && !lsd.bad_blocks ||
372:                                    ^
373:                    (                                 )


Unfortunately, even looking at this code and the patch that changed it,
I can't figure out what the correct parenthesis is for it.

Zheng, could you please send a patch to fix this?

Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)