linux-ext4 - Re: [PATCH] ext4: fix COLLAPSE RANGE test failure when bigalloc is enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Jul 2014 10:47:16 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Namjae Jeon <namjae.jeon@...sung.com>
Cc:	'linux-ext4' <linux-ext4@...r.kernel.org>,
	'Ashish Sangwan' <a.sangwan@...sung.com>
Subject: Re: [PATCH] ext4: fix COLLAPSE RANGE test failure when bigalloc is
 enable

On Thu, Jun 19, 2014 at 01:51:58PM +0900, Namjae Jeon wrote:
>  On Wed, Jun 04, 2014 at 05:08:45PM +0900, Namjae Jeon wrote:
> > > Blocks in collapse range should be collapsed per cluster unit when bigalloc
> > > is enable. If bigalloc is not enable, EXT4_CLUSTER_SIZE will be same with
> > > EXT4_BLOCK_SIZE.
> > >
> > > Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
> > > Signed-off-by: Ashish Sangwan <a.sangwan@...sung.com>
> > 
> > Correct me if I'm wrong, but this patch enables COLLAPSE_RANGE when
> > bigalloc is enabled.  The commit description (and the one-line
> > summary) should emphasize this.
> Yes, You're right. I will update description.

I don't think I saw an updated description, so I've taken care of
updating the description and applied the patch:

commit 3c17714e61314b101fb9bb671e7191ef1e9e63f3
Author: Namjae Jeon <namjae.jeon@...sung.com>
Date:   Tue Jul 29 10:45:31 2014 -0400

    ext4: fix COLLAPSE RANGE test for bigalloc file systems
    
    Blocks in collapse range should be collapsed per cluster unit when
    bigalloc is enable. If bigalloc is not enable, EXT4_CLUSTER_SIZE will
    be same with EXT4_BLOCK_SIZE.
    
    With this bug fixed, patch enables COLLAPSE_RANGE for bigalloc, which
    fixes a large number of xfstest failures which use fsx.
    
    Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
    Signed-off-by: Ashish Sangwan <a.sangwan@...sung.com>
    Signed-off-by: Theodore Ts'o <tytso@....edu>

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html