linux-ext4 - Re: [PATCH] ext3: dump dentry in ext3_dx_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 03 Feb 2015 11:39:36 +0100
From:	Bernd Schubert <bernd.schubert@...tmail.fm>
To:	Olaf Hering <olaf@...fle.de>, linux-ext4@...r.kernel.org
CC:	Jan Kara <jack@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>,
	Andreas Dilger <adilger.kernel@...ger.ca>
Subject: Re: [PATCH] ext3: dump dentry in ext3_dx_add_entry



On 02/03/2015 10:22 AM, Olaf Hering wrote:
> Signed-off-by: Olaf Hering <olaf@...fle.de>
> Cc: Jan Kara <jack@...e.cz>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Andreas Dilger <adilger.kernel@...ger.ca>
> ---
>  fs/ext3/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
> index f197736..0692058 100644
> --- a/fs/ext3/namei.c
> +++ b/fs/ext3/namei.c
> @@ -1529,7 +1529,7 @@ static int ext3_dx_add_entry(handle_t *handle, struct dentry *dentry,
>  		if (levels && (dx_get_count(frames->entries) ==
>  			       dx_get_limit(frames->entries))) {
>  			ext3_warning(sb, __func__,
> -				     "Directory index full!");
> +				     "Directory index full! %pd4 %pd", dentry->d_parent, dentry);
>  			err = -ENOSPC;
>  			goto cleanup;
>  		}

Would you mind to also add the inode number? That way one could use
debugfs to figure out the complete path.
And it should be done for ext4 as well.



Cheers,
Bernd
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html