linux-ext4 - Re: [PATCH 11/35] undo-io: be more flexible about setting block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 May 2015 10:21:28 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 11/35] undo-io: be more flexible about setting block size

On Wed, Apr 01, 2015 at 07:35:13PM -0700, Darrick J. Wong wrote:
> Most of the e2fsprogs utilities set the IO block size multiple times
> (once to 1k to read the superblock, then again to set the real block
> size if we find a real superblock).  Unfortunately, the undo IO
> manager only lets the block size be set once.  For the non-mke2fs
> utilities we'd rather catch the real block size and use that.  mke2fs
> of course wants to use a really large block size since it's probably
> writing a lot of data.
> 
> Therefore, if we haven't written any blocks to the undo file, it's
> perfectly fine to allow block size changes.  For mke2fs, we'll modify
> the IO channel option that lets us set the huge size to lock that
> in place.  This greatly reduces index overhead for undo files for
> e2fsck/tune2fs/resize2fs while continuing the practice of reducing
> it even more for mke2fs.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html