lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 May 2015 15:15:21 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Jaegeuk Kim <jaegeuk@...nel.org> Cc: davem@...emloft.net, linux-crypto@...r.kernel.org, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, ecryptfs@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] crypto: allow to assign gfp_t for __crypto_alloc_tfm On Tue, May 19, 2015 at 12:13:17AM -0700, Jaegeuk Kim wrote: > > The key generation is done by ext4_generate_encryption_key in > fs/ext4/crypto_key.c. > And, ext4_file_mmap and ext4_file_open trigger it. Well that's where you should be doing crypto_alloc_ablkcipher and crypto_ablkcipher_setkey. The whole point of a crypto tfm is to represent a key so any time you get one you should create a crypto tfm. Carrying around a raw key is just wrong. Cheers, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists