lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 8 Jun 2015 17:37:40 +0200 From: Michal Hocko <mhocko@...e.cz> To: Theodore Ts'o <tytso@....edu> Cc: linux-ext4@...r.kernel.org, David Rientjes <rientjes@...gle.com>, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH -resend] jbd2: revert must-not-fail allocation loops back to GFP_NOFAIL On Mon 08-06-15 10:54:32, Theodore Ts'o wrote: > On Mon, Jun 08, 2015 at 03:28:44PM +0200, Michal Hocko wrote: > > This basically reverts 47def82672b3 (jbd2: Remove __GFP_NOFAIL from jbd2 > > layer). The deprecation of __GFP_NOFAIL was a bad choice because it led > > to open coding the endless loop around the allocator rather than > > removing the dependency on the non failing allocation. So the > > deprecation was a clear failure and the reality tells us that > > __GFP_NOFAIL is not even close to go away. > > > > It is still true that __GFP_NOFAIL allocations are generally discouraged > > and new uses should be evaluated and an alternative (pre-allocations or > > reservations) should be considered but it doesn't make any sense to lie > > the allocator about the requirements. Allocator can take steps to help > > making a progress if it knows the requirements. > > > > Signed-off-by: Michal Hocko <mhocko@...e.cz> > > Acked-by: David Rientjes <rientjes@...gle.com> > > Applied, thanks. Thanks! -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists