linux-ext4 - Re: [PATCH 14/14] misc: add fuse2fs, a FUSE server for e2fsprogs (v4.3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Jun 2015 15:21:45 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 14/14] misc: add fuse2fs, a FUSE server for e2fsprogs
 (v4.3)

On Mon, Jun 15, 2015 at 11:37:05AM -0700, Darrick J. Wong wrote:
> On Wed, Jun 10, 2015 at 08:13:37PM -0400, Theodore Ts'o wrote:
> > On Wed, May 13, 2015 at 05:22:40PM -0700, Darrick J. Wong wrote:
> > > This is the initial implementation of a FUSE server based on
> > > e2fsprogs.  The point of this program is to enable ext4 to run on any
> > > OS that FUSE supports (and doesn't already have a native driver), such
> > > as MacOS X, BSDs, and Windows.  The code requires FUSE API v28, which
> > > is available in Linux fuse and osxfuse releases that are available as
> > > of August 2013.
> > 
> > Thanks, applied.
> 
> Hi Ted,
> 
> There's a merge error with this patch; the commit in -next removes all
> the Makefile dependencies from misc/Makefile.in, whereas the patch
> adds entries for {journal,revoke,recovery}.o.
> 
> This breaks a clean build because make doesn't know that it has
> to generate profile.h for mke2fs.c.

It wasn't caused by a merge error; this patch added
$(srcdir)/do_journal.c to SRCS (I'm guessing this was a cut and paste
error), and this caused the "make depend" to blow out, and this caused
the Makefile to lose all of its dependencies.  (To be fair, one of my
commits, 81f95d43d: "libext2fs, libe2p, misc: git rid of jfs_user.h"
also had a bug which caused "make depend" to fail as well.)

Anyway, I'll check in a fix.  Thanks for the report!

						- Ted

P.S.  Could you take a look at my reply to your patch #16/14?
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html