linux-ext4 - Re: [PATCH 15/19] resize2fs: Remove duplicit condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Aug 2015 18:12:46 +0200
From:	Jan Kara <jack@...e.cz>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	Jan Kara <jack@...e.com>, linux-ext4@...r.kernel.org,
	Ted Tso <tytso@....edu>,
	"Darrick J. Wong" <darrick.wong@...cle.com>
Subject: Re: [PATCH 15/19] resize2fs: Remove duplicit condition

On Fri 07-08-15 13:01:13, Andreas Dilger wrote:
> On Aug 7, 2015, at 4:51 AM, Jan Kara <jack@...e.com> wrote:
> > Subject: [PATCH 15/19] resize2fs: Remove duplicit condition
> 
> 
> Minor typo - s/duplicit/duplicate/

Thanks. Fixed.

								Honza

> 
> > Signed-off-by: Jan Kara <jack@...e.com>
> > ---
> > resize/resize2fs.c | 12 +-----------
> > 1 file changed, 1 insertion(+), 11 deletions(-)
> > 
> > diff --git a/resize/resize2fs.c b/resize/resize2fs.c
> > index 9a8be30bbce1..22300836300d 100644
> > --- a/resize/resize2fs.c
> > +++ b/resize/resize2fs.c
> > @@ -682,19 +682,9 @@ static errcode_t adjust_superblock(ext2_resize_t rfs, blk64_t new_size)
> > 	}
> > 
> > 	/*
> > -	 * If we are shrinking the number block groups, we're done and
> > +	 * If we are not increasing the number block groups, we're done and
> > 	 * can exit now.
> > 	 */
> > -	if (rfs->old_fs->group_desc_count > fs->group_desc_count) {
> > -		retval = 0;
> > -		goto errout;
> > -	}
> > -
> > -	/*
> > -	 * If the number of block groups is staying the same, we're
> > -	 * done and can exit now.  (If the number block groups is
> > -	 * shrinking, we had exited earlier.)
> > -	 */
> > 	if (rfs->old_fs->group_desc_count >= fs->group_desc_count) {
> > 		retval = 0;
> > 		goto errout;
> > -- 
> > 2.1.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> Cheers, Andreas
> 
> 
> 
> 
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html