linux-ext4 - Re: [PATCH 03/12] generic/80[0-2]: support xfs in addition to btrfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 08 Oct 2015 15:33:59 +0300
From:	Ari Sundholm <ari@...era.com>
To:	"Darrick J. Wong" <darrick.wong@...cle.com>
Cc:	"david@...morbit.com" <david@...morbit.com>,
	"Anna.Schumaker@...app.com" <Anna.Schumaker@...app.com>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
	"fstests@...r.kernel.org" <fstests@...r.kernel.org>,
	"xfs@....sgi.com" <xfs@....sgi.com>
Subject: Re: [PATCH 03/12] generic/80[0-2]: support xfs in addition to btrfs

On Wed, 2015-10-07 at 05:13 +0000, Darrick J. Wong wrote:
> Modify the reflink tests to support xfs.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> ---
>  common/rc         |   37 +++++++++++++++++++++++++++++++++++++
>  tests/generic/800 |    2 +-
>  tests/generic/801 |    2 +-
>  tests/generic/802 |    2 +-
>  4 files changed, 40 insertions(+), 3 deletions(-)
> 
> 
> diff --git a/common/rc b/common/rc
> index 3e97060..7e2f140 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1429,6 +1429,43 @@ _require_scratch_xfs_crc()
>  	umount $SCRATCH_MNT
>  }
>  
> +# this test requires the test fs support reflink...
> +#
> +_require_test_reflink()
> +{
> +    case $FSTYP in
> +    xfs)
> +	xfs_info "${TEST_DIR}" | grep reflink=1 -c -q || _notrun "Reflink not supported by this filesystem type: $FSTYP"
> +	;;
> +    btrfs)
> +        true
> +        ;;
> +    *)
> +        _notrun "Reflink not supported by this filesystem type: $FSTYP"
> +        ;;
> +    esac
> +}
> +
> +# this test requires the scratch fs support reflink...
> +#
> +_require_scratch_reflink()
> +{
> +    case $FSTYP in
> +    xfs)
> +	_scratch_mkfs > /dev/null 2>&1
> +	_scratch_mount
> +	xfs_info "${TEST_DIR}" | grep reflink=1 -c -q || _notrun "$FSTYP does not support reflink"

${SCRATCH_MNT}?

> +	_scratch_unmount
> +	;;
> +    btrfs)
> +        true
> +        ;;
> +    *)
> +        _notrun "Reflink not supported by this filesystem type: $FSTYP"
> +        ;;
> +    esac
> +}
> +
>  # this test requires the bigalloc feature to be available in mkfs.ext4
>  #
>  _require_ext4_mkfs_bigalloc()
> diff --git a/tests/generic/800 b/tests/generic/800
> index a71f11a..954f39d 100755
> --- a/tests/generic/800
> +++ b/tests/generic/800
> @@ -45,7 +45,7 @@ _cleanup()
>  . common/filter
>  
>  # real QA test starts here
> -_supported_fs btrfs
> +_require_test_reflink
>  _supported_os Linux
>  
>  _require_xfs_io_command "fiemap"
> diff --git a/tests/generic/801 b/tests/generic/801
> index b21c44b..aedb6e9 100755
> --- a/tests/generic/801
> +++ b/tests/generic/801
> @@ -45,7 +45,7 @@ _cleanup()
>  . common/filter
>  
>  # real QA test starts here
> -_supported_fs btrfs
> +_require_test_reflink
>  _supported_os Linux
>  
>  _require_xfs_io_command "fiemap"
> diff --git a/tests/generic/802 b/tests/generic/802
> index afd8513..51d3414 100755
> --- a/tests/generic/802
> +++ b/tests/generic/802
> @@ -43,7 +43,7 @@ _cleanup()
>  . ./common/filter
>  
>  # real QA test starts here
> -_supported_fs btrfs
> +_require_test_reflink
>  _supported_os Linux
>  
>  _require_xfs_io_command "fiemap"
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html