linux-ext4 - [PATCH] ext4: fix ext4_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 08 Jan 2016 22:52:44 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Theodore Ts'o <tytso@....edu>
Cc:	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, Li Xi <lixi@....com>,
	Jan Kara <jack@...e.cz>
Subject: [PATCH] ext4: fix ext4_ioctl_setproject return code

The newly introduced ext4_ioctl_setproject() functions comes in two
versions, one is fine and the other has an undefined return value,
as indicated by a compiler warning:

fs/ext4/ioctl.c:426:1: warning: control reaches end of non-void function [-Wreturn-type]
fs/ext4/ioctl.c: In function 'ext4_ioctl_setproject':

This changes the function to return zero on success, as the other
version does.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
Fixes: e14c6dbc6429 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support")
---
Found on ARM randconfig testing on the last two linux-next releases.

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index c1d45aaa7d55..946560cb3fe6 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -423,6 +423,7 @@ static int ext4_ioctl_setproject(struct file *filp, __u32 projid)
 {
 	if (projid != EXT4_DEF_PROJID)
 		return -EOPNOTSUPP;
+	return 0;
 }
 #endif
 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html