linux-ext4 - Re: [PATCH] fs: XFS_IOC_FS[SG]SETXATTR to FS_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Jan 2016 19:56:44 -0500
From:	Pranith Kumar <bobby.prani@...il.com>
To:	Dave Chinner <david@...morbit.com>
Cc:	Li Xi <pkuelelixi@...il.com>,
	"open list:OVERLAYFS FILESYSTEM" <linux-fsdevel@...r.kernel.org>,
	linux-ext4@...r.kernel.org,
	"open list:KERNEL SELFTEST F..." <linux-api@...r.kernel.org>,
	"Theodore Ts'o" <tytso@....edu>, adilger@...ger.ca,
	Jan Kara <jack@...e.cz>, Al Viro <viro@...iv.linux.org.uk>,
	hch@...radead.org, dmonakhov@...nvz.org
Subject: Re: [PATCH] fs: XFS_IOC_FS[SG]SETXATTR to FS_IOC_FS[SG]ETXATTR promotion

On Sun, Jan 3, 2016 at 6:05 PM, Dave Chinner <david@...morbit.com> wrote:
> On Sun, Sep 13, 2015 at 09:20:32PM +0900, Li Xi wrote:
>> This patch adds FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR ioctl interface
>> support for ext4. The interface is kept consistent with
>> XFS_IOC_FSGETXATTR/XFS_IOC_FSGETXATTR.
>>
>> Signed-off-by: Li Xi <lixi@....com>
>> Reviewed-by: Andreas Dilger <adilger@...ger.ca>
>> Reviewed-by: Jan Kara <jack@...e.cz>
>

Hello,

This commit breaks building latest qemu as follows:

In file included from /usr/include/xfs/xfs.h:58:0,
                 from /home/pranith/qemu/block/raw-posix.c:96:
/usr/include/xfs/xfs_fs.h:42:8: error: redefinition of ‘struct fsxattr’
 struct fsxattr {
        ^
In file included from /home/pranith/qemu/block/raw-posix.c:59:0:
/usr/include/linux/fs.h:155:8: note: originally defined here
 struct fsxattr {
        ^
/home/pranith/qemu/rules.mak:57: recipe for target 'block/raw-posix.o' failed

I think this is caused by moving the fsxattr struct around. Is the
header inclusion messed up somehow?

Thanks,

-- 
Pranith
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html