lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Mar 2016 09:41:30 +0100 From: Jan Kara <jack@...e.cz> To: Luis de Bethencourt <luisbg@....samsung.com> Cc: linux-kernel@...r.kernel.org, tytso@....edu, jack@...e.com, linux-ext4@...r.kernel.org Subject: Re: [PATCH] jbd2: remove excess descriptions for handle_s On Sat 19-03-16 17:06:03, Luis de Bethencourt wrote: > Commit bf6993276f74 ("jbd2: Use tracepoints for history file") > removed the members j_history, j_history_max and j_history_cur from struct > handle_s but the descriptions stayed lingering. Removing them. > > Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com> Looks good. You can add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > Hi, > > Noticed this issue when running make htmldocs. > > It gives the following warnings: > .//include/linux/jbd2.h:1033: warning: Excess struct/union/enum/typedef member 'j_history' description in 'journal_s' > .//include/linux/jbd2.h:1033: warning: Excess struct/union/enum/typedef member 'j_history_max' description in 'journal_s' > .//include/linux/jbd2.h:1033: warning: Excess struct/union/enum/typedef member 'j_history_cur' description in 'journal_s' > > Thanks, > Luis > > include/linux/jbd2.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h > index fd1083c..401792d 100644 > --- a/include/linux/jbd2.h > +++ b/include/linux/jbd2.h > @@ -781,9 +781,6 @@ jbd2_time_diff(unsigned long start, unsigned long end) > * @j_wbufsize: maximum number of buffer_heads allowed in j_wbuf, the > * number that will fit in j_blocksize > * @j_last_sync_writer: most recent pid which did a synchronous write > - * @j_history: Buffer storing the transactions statistics history > - * @j_history_max: Maximum number of transactions in the statistics history > - * @j_history_cur: Current number of transactions in the statistics history > * @j_history_lock: Protect the transactions statistics history > * @j_proc_entry: procfs entry for the jbd statistics directory > * @j_stats: Overall statistics > -- > 2.5.1 > > -- Jan Kara <jack@...e.com> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists