linux-ext4 - Re: [PATCH] e2image: ignore checksum errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 Apr 2016 15:01:45 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Theodore Ts'o <tytso@....edu>
Cc:	"Darrick J. Wong" <darrick.wong@...cle.com>,
	linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2image: ignore checksum errors


> On Apr 25, 2016, at 10:03 AM, Theodore Ts'o <tytso@....edu> wrote:
> 
> On Tue, Apr 19, 2016 at 12:20:30PM -0700, Darrick J. Wong wrote:
>> Since e2image is used to capture broken fs images for debugging,
>> ignore checksum errors when creating the image.
>> 
>> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> 
> Thanks, applied.
> 
> BTW, the "m" series in tests was originally intended to be for mke2fs
> tests.  However, some MMP tests have already been named m_*, and it
> seems some folks have been assuming that miscellaneous tests should be
> named m_*.

I think the "m_mmp" test is appropriately named, since it is testing
enabling MMP at mke2fs time.  The "m_mmp_bad_{csum,magic}" tests were
added later, and I agree they should probably be renamed "f_mmp_bad_*".

Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)