linux-ext4 - Re: [PATCH 3/7] ext2: Avoid DAX zeroing to corrupt data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 May 2016 17:56:02 +0000
From:	"Verma, Vishal L" <vishal.l.verma@...el.com>
To:	"jack@...e.cz" <jack@...e.cz>
CC:	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"ross.zwisler@...ux.intel.com" <ross.zwisler@...ux.intel.com>,
	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
	"Williams, Dan J" <dan.j.williams@...el.com>,
	"tytso@....edu" <tytso@....edu>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 3/7] ext2: Avoid DAX zeroing to corrupt data

On Tue, 2016-05-17 at 09:19 +0200, Jan Kara wrote:
> On Tue 17-05-16 06:52:47, Verma, Vishal L wrote:

[...]

> > 
> > 
> > -               err = dax_clear_sectors(inode->i_sb->s_bdev,
> > -                               le32_to_cpu(chain[depth-1].key) <<
> > -                               (inode->i_blkbits - 9),
> > -                               1 << inode->i_blkbits);
> > +               err = sb_issue_zeroout(inode->i_sb,
> > +                               le32_to_cpu(chain[depth-1].key),
> > count, GFP_NOFS);
> > 
> > If so, I'll update my series tomorrow to include in both of these
> > changes.
> I'd prefer these two to stay separate commits (they are really
> independent).  Since you already depend on other patches from the DAX
> cleanup series, just add this patch to the list of dependencies and
> base
> your change on that... Hmm?

Yes I agree. I'm preparing a branch that adds your fix, and modifying my
sb_issue_zeroout to use the same fix. I've verified that those tests
pass after both changes.

Thanks!
	-Vishal