linux-ext4 - Re: [PATCH] ext4: add ability to control the pseudo-random seed used by ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 30 Jul 2016 03:39:23 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Theodore Ts'o <tytso@....edu>
Cc:	kbuild-all@...org,
	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	agayev@...il.com, Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH] ext4: add ability to control the pseudo-random seed used
 by ext4

Hi,

[auto build test WARNING on ext4/dev]
[also build test WARNING on v4.7 next-20160729]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Theodore-Ts-o/ext4-add-ability-to-control-the-pseudo-random-seed-used-by-ext4/20160730-001338
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:6:0,
                    from include/linux/kernel.h:13,
                    from include/linux/list.h:8,
                    from include/linux/preempt.h:10,
                    from include/linux/spinlock.h:50,
                    from include/linux/seqlock.h:35,
                    from include/linux/time.h:5,
                    from fs/ext4/ialloc.c:15:
   fs/ext4/ialloc.c: In function 'find_group_orlov':
>> include/linux/kern_levels.h:4:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'ext4_group_t {aka unsigned int}' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:10:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^
   include/linux/printk.h:264:9: note: in expansion of macro 'KERN_ERR'
     printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
            ^
>> fs/ext4/ialloc.c:490:4: note: in expansion of macro 'pr_err'
       pr_err("ext4 random: %lu\n", grp);
       ^

vim +/pr_err +490 fs/ext4/ialloc.c

   474		do_div(avefreec, ngroups);
   475		ndirs = percpu_counter_read_positive(&sbi->s_dirs_counter);
   476	
   477		if (S_ISDIR(mode) &&
   478		    ((parent == d_inode(sb->s_root)) ||
   479		     (ext4_test_inode_flag(parent, EXT4_INODE_TOPDIR)))) {
   480			int best_ndir = inodes_per_group;
   481			int ret = -1;
   482	
   483			if (qstr) {
   484				hinfo.hash_version = DX_HASH_HALF_MD4;
   485				hinfo.seed = sbi->s_hash_seed;
   486				ext4fs_dirhash(qstr->name, qstr->len, &hinfo);
   487				grp = hinfo.hash;
   488			} else {
   489				grp = prandom_u32_state(&sbi->s_rnd_state);
 > 490				pr_err("ext4 random: %lu\n", grp);
   491			}
   492			parent_group = (unsigned)grp % ngroups;
   493			for (i = 0; i < ngroups; i++) {
   494				g = (parent_group + i) % ngroups;
   495				get_orlov_stats(sb, g, flex_size, &stats);
   496				if (!stats.free_inodes)
   497					continue;
   498				if (stats.used_dirs >= best_ndir)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (46457 bytes)